DM-51248: Raise error if no kernel candidates remain after max iterations#405
Merged
DM-51248: Raise error if no kernel candidates remain after max iterations#405
Conversation
kfindeisen
approved these changes
Jun 3, 2025
Member
kfindeisen
left a comment
kfindeisen
left a comment
There was a problem hiding this comment.
Looks good, procedural points only.
python/lsst/ip/diffim/psfMatch.py
Outdated
|
|
||
| if spatialkv.getNCandidates() < 1: | ||
| # Run after the final fit to use the updated kernel visitor `spatialkv` | ||
| raise RuntimeError("No kernel candidates remain after max iterations") |
Member
There was a problem hiding this comment.
Should this be an AlgorithmError or something fancier? I don't know what the rules are for task exceptions these days.
Contributor
Author
There was a problem hiding this comment.
Yes, that would be better. I should convert the similar RuntimeError into one as well.
python/lsst/ip/diffim/psfMatch.py
Outdated
| spatialKernel, spatialBackground = spatialkv.getSolutionPair() | ||
|
|
||
| if spatialkv.getNCandidates() < 1: | ||
| # Run after the final fit to use the updated kernel visitor `spatialkv` |
Member
There was a problem hiding this comment.
I missed this comment the first time around; I think putting it before the if might make it more obvious (since it refers to the whole block).
isullivan
force-pushed
the
tickets/DM-51248
branch
from
90b6c7f to
8678e89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.